FreeCalypso > hg > freecalypso-tools
view ffstools/tiffs-rd/xtr.c @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 11 Feb 2019 00:00:19 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * This C module implements the xtr command. */ #include <sys/types.h> #include <sys/file.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include <unistd.h> #include "types.h" #include "struct.h" #include "globals.h" #include "pathname.h" static void dump_head_chunk(fd, headino) { struct inode_info *inf = inode_info[headino]; struct chunkinfo chi; if (size_head_chunk(inf, &chi)) write(fd, chi.start, chi.len); } static void dump_extra_chunk(inf, opaque) struct inode_info *inf; u_long opaque; { int fd = (int)opaque; struct chunkinfo chi; size_extra_chunk(inf, &chi); write(fd, chi.start, chi.len); } extract_file(relpath, headino) char *relpath; { int fd; fd = open(relpath, O_WRONLY|O_CREAT|O_TRUNC, 0666); if (fd < 0) { perror(relpath); exit(1); } dump_head_chunk(fd, headino); iterate_seg_file(headino, dump_extra_chunk, (u_long)fd, 0, 0); close(fd); } void xtr_tree_callback(pathname, ino, depth) char *pathname; { struct inode_info *inf = inode_info[ino]; switch (inf->type) { case 0xE1: case 0xF1: /* skip /.journal; those who need it can cat it */ if (strcmp(pathname, "/.journal")) extract_file(pathname + 1, ino); return; case 0xE2: case 0xF2: if (mkdir(pathname + 1, 0777) < 0) { perror(pathname + 1); exit(1); } return; case 0xE3: case 0xF3: fprintf(stderr, "symlink at %s ignored: symlink extraction not implemented yet\n", pathname); return; default: fprintf(stderr, "BUG: bad inode byte %02X reached xtr_tree_callback()\n", inf->type); exit(1); } } cmd_xtr(argc, argv) char **argv; { if (argc != 2) { fprintf(stderr, "usage: xtr dest-dir\n"); exit(1); } read_ffs_image(); find_inode_block(); alloc_inode_table(); find_root_inode(); if (chdir(argv[1]) < 0) { perror(argv[1]); exit(1); } traverse_visible_tree(xtr_tree_callback); exit(0); }