FreeCalypso > hg > freecalypso-tools
view libserial-orig/baudtab.c @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 11 Feb 2019 00:00:19 +0000 |
parents | cb1ba53a1106 |
children | 39b39b546824 |
line wrap: on
line source
/* * This module contains the table of baud rates supported * by this implementation of FreeCalypso libserial. */ #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include <termios.h> #include "baudrate.h" struct baudrate baud_rate_table[] = { /* the first listed rate will be our default */ {"115200", B115200, 0}, {"57600", B57600, 1}, {"38400", B38400, 2}, {"19200", B19200, 4}, /* * Non-standard high baud rates remapped by CP2102 EEPROM programming * or by a hacky patch to the ftdi_sio Linux kernel driver to work * with FTDI adapters. */ {"812500", B921600, -1}, {"406250", B460800, -1}, {"203125", B230400, -1}, /* table search terminator */ {NULL, B0, -1}, }; struct baudrate * find_baudrate_by_name(srch_name) char *srch_name; { struct baudrate *br; for (br = baud_rate_table; br->name; br++) if (!strcmp(br->name, srch_name)) break; if (br->name) return(br); else { fprintf(stderr, "error: baud rate \"%s\" not known\n", srch_name); return(NULL); } }