FreeCalypso > hg > freecalypso-tools
view loadtools/CHANGES @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 11 Feb 2019 00:00:19 +0000 |
| parents | e7502631a0f9 |
| children |
line wrap: on
line source
Changes from loadtools-r2 to fc-host-tools-r3: * Implemented support for Mot C1xx (Compal) targets in addition to the previously supported Openmoko and Pirelli. Compal phones have different flash, require a different procedure for gaining code download access, and have additional bricking concerns. * Updated loadagent includes Intel flash support and ABB commands needed for Compal phones. * The range of IRAM addresses used by loadagent changed to allow gsm-fw ramImage builds (chain-loaded with fc-xram) to load their IRAM code section directly into place. * Loadtool's flash program-bin command now automatically performs a CRC-32 verification after programming. * Miscellaneous minor polish. Changes from loadtools-r1 to loadtools-r2: * A flash ID check has been implemented in fc-loadtool, invoked automatically before doing any erase or program operations, or explicitly at any time with the flash info command. This check ensures that the type of flash chip in the target GSM device is the same as what loadtool thinks it is, based on the hardware parameters file. * fc-xram command line syntax changed slightly in order to support immediate passing of the serial line to rvinterf/rvtdump. * Miscellaneous minor polish.