view rvinterf/asyncshell/tchrec.c @ 465:003e48f8ebe1

rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 11 Feb 2019 00:00:19 +0000
parents 971906d7763d
children 8171c5c0d804
line wrap: on
line source

/*
 * TCH downlink recording functionality
 */

#include <sys/types.h>
#include <stdio.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include "pktmux.h"
#include "tch_feature.h"

extern u_char rvi_msg[];
extern int rvi_msg_len;

static FILE *record_file;
static u_long frame_count;

void
tch_dlbits_handler()
{
	u_char *ptr;
	int i;

	if (!record_file)
		return;
	/* DSP status words */
	ptr = rvi_msg + 3;
	for (i = 0; i < 3; i++) {
		fprintf(record_file, "%02X%02X ", ptr[0], ptr[1]);
		ptr += 2;
	}
	/* frame bits */
	for (i = 0; i < 33; i++) {
		fprintf(record_file, "%02X", *ptr);
		ptr++;
	}
	putc('\n', record_file);
	frame_count++;
}

static void
cmd_tch_record_start(filename)
	char *filename;
{
	if (record_file) {
		printf("error: tch record session already in progress\n");
		return;
	}
	record_file = fopen(filename, "w");
	if (!record_file) {
		perror(filename);
		return;
	}
	printf("Starting TCH DL recording\n");
	tch_rx_control(1);
	send_tch_config_req(1);
	frame_count = 0;
}

static void
cmd_tch_record_stop()
{
	if (!record_file) {
		printf("error: no tch record session in progress\n");
		return;
	}
	fclose(record_file);
	record_file = 0;
	printf("TCH DL recording stopped, captured %lu speech frames\n",
		frame_count);
	send_tch_config_req(0);
}

void
cmd_tch_record(argc, argv)
	char **argv;
{
	if (argc < 2) {
		printf("error: too few arguments\n");
		return;
	}
	if (strcmp(argv[1], "stop"))
		cmd_tch_record_start(argv[1]);
	else
		cmd_tch_record_stop();
}

void
show_tch_record_status()
{
	printf("TCH DL recording: %s\n",
		record_file ? "RUNNING" : "not running");
}