FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/fscmdtab.c @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 11 Feb 2019 00:00:19 +0000 |
| parents | 0cb766828d7a |
| children | adcb617e6a92 |
line wrap: on
line source
/* * fc-fsio command dispatch table */ #include "cmdtab.h" extern int cmd_cpout(); extern int cmd_cpout_file(); extern int cmd_delete(); extern int cmd_dieid(); extern int cmd_exec(); extern int cmd_exit(); extern int cmd_fd(); extern int cmd_ffs2ver(); extern int cmd_format(); extern int cmd_fwrite(); extern int cmd_hd(); extern int cmd_help(); extern int cmd_ll(); extern int cmd_ls(); extern int cmd_memdump(); extern int cmd_mkdir(); extern int cmd_omemdump(); extern int cmd_preformat(); extern int cmd_readlink(); extern int cmd_set_imeisv(); extern int cmd_set_pcm_string(); extern int cmd_set_rfcap(); extern int cmd_stat(); extern int cmd_symlink(); extern int cmd_uploadfs(); extern int cmd_upload_file(); extern int cmd_upload_rf_table(); extern int cmd_upload_subtree(); extern int cmd_write_battery_table(); extern int cmd_write_charging_config(); extern int create_std_dirs(); extern int get_pirelli_imei(); extern int pirelli_magnetite_init(); struct cmdtab cmdtab[] = { {"cpout", 2, 2, cmd_cpout}, {"cpout-file", 2, 2, cmd_cpout_file}, {"create-std-dirs", 0, 0, create_std_dirs}, {"delete", 1, 1, cmd_delete}, {"dieid", 0, 0, cmd_dieid}, {"exec", 1, 1, cmd_exec}, {"exit", 0, 0, cmd_exit}, {"fd", 2, 3, cmd_fd}, {"ffs2ver", 0, 0, cmd_ffs2ver}, {"format", 1, 1, cmd_format}, {"fwrite", 3, 3, cmd_fwrite}, {"hd", 1, 1, cmd_hd}, {"help", 0, 1, cmd_help}, {"ll", 1, 1, cmd_ll}, {"ls", 1, 2, cmd_ls}, {"memdump", 2, 2, cmd_memdump}, {"mkdir", 1, 1, cmd_mkdir}, {"mk-std-dirs", 0, 0, create_std_dirs}, {"omemdump", 2, 2, cmd_omemdump}, {"pirelli-get-imei", 0, 0, get_pirelli_imei}, {"pirelli-magnetite-init", 0, 0, pirelli_magnetite_init}, {"preformat", 0, 0, cmd_preformat}, {"readlink", 1, 1, cmd_readlink}, {"set-imeisv", 2, 2, cmd_set_imeisv}, {"set-pcm-string", 2, 2, cmd_set_pcm_string}, {"set-rfcap", 1, 1, cmd_set_rfcap}, {"stat", 1, 1, cmd_stat}, {"symlink", 2, 2, cmd_symlink}, {"upload-file", 2, 2, cmd_upload_file}, {"upload-fs", 1, 1, cmd_uploadfs}, {"upload-rf-table", 1, 2, cmd_upload_rf_table}, {"upload-subtree", 2, 2, cmd_upload_subtree}, {"write-battery-table", 1, 1, cmd_write_battery_table}, {"write-charging-config", 1, 1, cmd_write_charging_config}, {0, 0, 0, 0} };