FreeCalypso > hg > freecalypso-tools
view rvinterf/include/etm.h @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 11 Feb 2019 00:00:19 +0000 |
| parents | e7502631a0f9 |
| children | c535e7438c25 |
line wrap: on
line source
/* * This header file contains various definitions for talking to ETM. */ #define ETM_USE_ID 0x001E0004 /* ETM Module IDs */ enum { ETM_TM3 = 0x00, // Use of old TM3 protocol ETM_CORE = 0x01, ETM_TMT = 0x02, // Pseudo module ETM_SH = 0x03, // Pseudo module ETM_TM3_MISC = 0x04, // Pseudo module - Target side ETM_RF = 0x05, ETM_IMEI = 0x06, ETM_FFS2 = 0x07, ETM_AUDIO = 0x08, ETM_TPU = 0x09, // Not official part ETM ETM_PWR = 0x0A, ETM_BT = 0x0B, ETM_L23 = 0x0C, ETM_RESERVED10 = 0x0D, ETM_RESERVED11 = 0x0E, ETM_RESERVED12 = 0x0F, ETM_CUST = 0xC0, // Customize id ETM_CUST1 = 0xC1, // Customize id ETM_CUST2 = 0xC2, // Customize id ETM_CUST3 = 0xC3, // Customize id ETM_CUST4 = 0xC4, // Customize id ETM_CUST5 = 0xC5, // Customize id ETM_CUST6 = 0xC6, // Customize id ETM_CUST7 = 0xC7, // Customize id ETM_CUST8 = 0xC8, // Customize id ETM_TEST = 0xAA, // used for test of dll's ETM_TASK = 0xEE, // ETM TASK in Target ETM_FFS1 = 0x70 }; /* ETM_CORE opcodes */ #define TMCORE_OPC_MEM 0x61 #define TMCORE_OPC_ECHO 0x62 #define TMCORE_OPC_RESET 0x63 #define TMCORE_OPC_DEBUG 0x64 #define TMCORE_OPC_VERSION 0x65 #define TMCORE_OPC_CODEC_RD 0x66 #define TMCORE_OPC_CODEC_WR 0x67 #define TMCORE_OPC_DIEID 0x68 #define MAX_MEMREAD_BYTES 238 #define MAX_MEMREAD_16BIT 119