FreeCalypso > hg > freecalypso-tools
view rvinterf/tmsh/saverftab.c @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 11 Feb 2019 00:00:19 +0000 |
parents | 6b01d4ef85c3 |
children |
line wrap: on
line source
/* * Here we implement fc-tmsh operator commands which save the RF table data * received via rftr and ttr commands into files. */ #include <sys/types.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "l1tm.h" #include "exitcodes.h" extern unsigned rftr_table_index, rftr_table_size; extern u_char rftr_table_data[]; extern u_char ttr_ramp_data[]; extern void write_afcparams_table(); extern void write_agcwords_table(); extern void write_agcglobals_table(); extern void write_il2agc_table(); extern void write_tx_levels_table(); extern void write_tx_calchan_table(); extern void write_tx_caltemp_table(); extern void write_rx_calchan_table(); extern void write_rx_caltemp_table(); extern void write_rx_agcparams_table(); static struct table_map { int index; int size; void (*func)(); } table_map[] = { {RX_AGC_TABLE, 40, write_agcwords_table}, {AFC_PARAMS, 24, write_afcparams_table}, {RX_AGC_GLOBAL_PARAMS, 8, write_agcglobals_table}, {RX_IL_2_AGC_MAX, 121, write_il2agc_table}, {RX_IL_2_AGC_PWR, 121, write_il2agc_table}, {RX_IL_2_AGC_AV, 121, write_il2agc_table}, {TX_LEVELS, 128, write_tx_levels_table}, {TX_CAL_CHAN, 128, write_tx_calchan_table}, {TX_CAL_TEMP, 40, write_tx_caltemp_table}, {RX_CAL_CHAN, 40, write_rx_calchan_table}, {RX_CAL_TEMP, 44, write_rx_caltemp_table}, {RX_AGC_PARAMS, 8, write_rx_agcparams_table}, {0, 0, 0} }; cmd_save_rf_table(argc, argv) char **argv; { struct table_map *tp; FILE *outf; if (!rftr_table_size) { printf("error: no RF table has been received\n"); return(ERROR_TARGET); } for (tp = table_map; tp->index; tp++) { if (tp->index == rftr_table_index) break; } if (!tp->index) { printf("error: received table index %u not known\n", rftr_table_index); return(ERROR_TARGET); } if (rftr_table_size != tp->size && (rftr_table_index != RX_AGC_PARAMS || rftr_table_size != 10)) { printf("error: received table index and size don't match\n"); return(ERROR_TARGET); } outf = fopen(argv[1], "w"); if (!outf) { perror(argv[1]); return(ERROR_UNIX); } tp->func(rftr_table_data, outf); fclose(outf); return(0); } cmd_save_rf_table_raw(argc, argv) char **argv; { FILE *outf; int off, l, j; if (!rftr_table_size) { printf("error: no RF table has been received\n"); return(ERROR_TARGET); } outf = fopen(argv[1], "w"); if (!outf) { perror(argv[1]); return(ERROR_UNIX); } fputs("rf_table raw\n\n", outf); for (off = 0; off < rftr_table_size; ) { l = rftr_table_size - off; if (l > 16) l = 16; for (j = 0; j < l; j++) { if (j) putc(' ', outf); if (j == 8) putc(' ', outf); fprintf(outf, "%02X", rftr_table_data[off++]); } putc('\n', outf); } fclose(outf); return(0); } cmd_save_tx_ramp(argc, argv) char **argv; { FILE *outf; outf = fopen(argv[1], "w"); if (!outf) { perror(argv[1]); return(ERROR_UNIX); } write_tx_ramp(ttr_ramp_data, outf); fclose(outf); return(0); }