FreeCalypso > hg > freecalypso-tools
view target-utils/c139explore/cmdtab.c @ 465:003e48f8ebe1
rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel
I generally don't use NULL and use plain 0 instead, based on a "NULL
considered harmful" discussion on the classiccmp mailing list many aeons
ago (I couldn't find it, and I reason that it must have been 2005 or
earlier), but a recent complaint by a packager sent me searching, and I
found this:
https://ewontfix.com/11/
While I don't give a @#$% about "modern" systems and code-nazi tools,
I realized that passing a plain 0 as a pointer sentinel in execl is wrong
because it will break on systems where pointers are longer than the plain
int type. Again, I don't give a @#$% about the abomination of x86_64 and
the like, but if anyone ever manages to port my code to something like a
PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0
as a function argument where a pointer is expected most definitely won't
work: if the most natural stack slot and SP alignment unit is 16 bits,
fitting an int, with longs and pointers taking up two such slots, then
the call stack will be totally wrong with a plain 0 passed for a pointer.
Casting the 0 to (char *) ought to be the most kosher solution for the
most retro systems possible.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 11 Feb 2019 00:00:19 +0000 |
| parents | 7ecb70b0ac36 |
| children | 44a1de4264d8 |
line wrap: on
line source
#include "cmdtab.h" extern void cmd_abbr(); extern void cmd_abbw(); extern void cmd_buz(); extern void cmd_buzlev(); extern void cmd_dac(); extern void cmd_dacon(); extern void cmd_dbl(); extern void cmd_hbars(); extern void cmd_jump(); extern void cmd_kpbl(); extern void cmd_lcdcmd(); extern void cmd_lcdfill(); extern void cmd_lcdinit(); extern void cmd_lcdpix(); extern void cmd_r8(); extern void cmd_r16(); extern void cmd_r32(); extern void cmd_vbars(); extern void cmd_vibe(); extern void cmd_w8(); extern void cmd_w16(); extern void cmd_w32(); extern void abb_init(); extern void abb_power_off(); extern void cmd_memdump_human(); const struct cmdtab cmdtab[] = { {"abbinit", abb_init}, {"abbr", cmd_abbr}, {"abbw", cmd_abbw}, {"buz", cmd_buz}, {"buzlev", cmd_buzlev}, {"dac", cmd_dac}, {"dacon", cmd_dacon}, {"dbl", cmd_dbl}, {"dump", cmd_memdump_human}, {"hbars", cmd_hbars}, {"jump", cmd_jump}, {"kpbl", cmd_kpbl}, {"lcdcmd", cmd_lcdcmd}, {"lcdfill", cmd_lcdfill}, {"lcdinit", cmd_lcdinit}, {"lcdpix", cmd_lcdpix}, {"poweroff", abb_power_off}, {"r8", cmd_r8}, {"r16", cmd_r16}, {"r32", cmd_r32}, {"vbars", cmd_vbars}, {"vibe", cmd_vibe}, {"w8", cmd_w8}, {"w16", cmd_w16}, {"w32", cmd_w32}, {0, 0} };