rvinterf/etmsync/fsnew.c: cast 0 to (char *) for execl sentinel I generally don't use NULL and use plain 0 instead, based on a "NULL considered harmful" discussion on the classiccmp mailing list many aeons ago (I couldn't find it, and I reason that it must have been 2005 or earlier), but a recent complaint by a packager sent me searching, and I found this: https://ewontfix.com/11/ While I don't give a @#$% about "modern" systems and code-nazi tools, I realized that passing a plain 0 as a pointer sentinel in execl is wrong because it will break on systems where pointers are longer than the plain int type. Again, I don't give a @#$% about the abomination of x86_64 and the like, but if anyone ever manages to port my code to something like a PDP-11 (16-bit int, 32-bit long and pointers), then passing a plain 0 as a function argument where a pointer is expected most definitely won't work: if the most natural stack slot and SP alignment unit is 16 bits, fitting an int, with longs and pointers taking up two such slots, then the call stack will be totally wrong with a plain 0 passed for a pointer. Casting the 0 to (char *) ought to be the most kosher solution for the most retro systems possible.

/*
 * This library module implements the function that distills the complex
 * set of possible SMS DCS octet values to just one of 4 possibilities:
 * 7-bit text (7), 8-bit data octets (8), UCS-2 text (16) or compressed
 * data (9).
 *
 * The decoding is based on the 3GPP TS 23.038 V11.0.0 spec;
 * reserved encodings are treated as 7-bit text as the spec instructs.
 */

sms_dcs_classify(dcs)
{
	if (!(dcs & 0x80)) {
		if (dcs & 0x20)
			return(9);
		switch (dcs & 0xC) {
		case 0:
			return(7);
		case 4:
			return(8);
		case 8:
			return(16);
		default:
			/* reserved, treating as 7-bit per the spec */
			return(7);
		}
	}
	switch (dcs & 0xF0) {
	case 0x80:
	case 0x90:
	case 0xA0:
	case 0xB0:
		/* reserved, treating as 7-bit per the spec */
		return(7);
	case 0xC0:
	case 0xD0:
		return(7);
	case 0xE0:
		return(16);
	case 0xF0:
		if (dcs & 4)
			return(8);
		else
			return(7);
	}
}