FreeCalypso > hg > freecalypso-tools
view ffstools/newcomp/compile-fc-batt.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | c79aaed75bd8 |
children |
line wrap: on
line source
/* * This utility compiles a table of battery thresholds for the 2017-12 version * of FreeCalypso battery management code from ASCII source into the binary * form suitable for uploading into /etc/batterytab on a FreeCalypso device. */ #include <ctype.h> #include <string.h> #include <strings.h> #include <stdio.h> #include <stdlib.h> #include "../../rvinterf/include/exitcodes.h" char *infname; FILE *inf, *outf; char linebuf[256]; int lineno, record_count; unsigned last_mv, last_percent; process_line() { char *cp; unsigned mv, percent; for (cp = linebuf; isspace(*cp); cp++) ; if (*cp == '\0' || *cp == '#') return(0); if (!isdigit(*cp)) { inv: fprintf(stderr, "%s line %d: invalid syntax\n", infname, lineno); exit(ERROR_USAGE); } mv = strtoul(cp, 0, 10); while (isdigit(*cp)) cp++; if (!isspace(*cp)) goto inv; while (isspace(*cp)) cp++; if (!isdigit(*cp)) goto inv; percent = strtoul(cp, 0, 10); while (isdigit(*cp)) cp++; if (*cp && !isspace(*cp)) goto inv; /* ignore possible third field added in 2020-11 for bars threshold */ if (mv > 0xFFFF) { fprintf(stderr, "%s line %d: the millivolt value is invalid\n", infname, lineno); exit(ERROR_USAGE); } if (percent > 100) { fprintf(stderr, "%s line %d: the percent value is invalid\n", infname, lineno); exit(ERROR_USAGE); } if (record_count) { if (mv >= last_mv) { fprintf(stderr, "%s line %d: millivolt numbers must be decreasing\n", infname, lineno); exit(ERROR_USAGE); } if (percent >= last_percent) { fprintf(stderr, "%s line %d: percent numbers must be decreasing\n", infname, lineno); exit(ERROR_USAGE); } } putc(mv, outf); putc(mv >> 8, outf); putc(percent, outf); putc(0, outf); last_mv = mv; last_percent = percent; record_count++; return(1); } main(argc, argv) char **argv; { if (argc != 3) { fprintf(stderr, "usage: %s srcfile output-binfile\n", argv[0]); exit(ERROR_USAGE); } infname = argv[1]; inf = fopen(infname, "r"); if (!inf) { perror(infname); exit(ERROR_UNIX); } outf = fopen(argv[2], "w"); if (!outf) { perror(argv[2]); exit(ERROR_UNIX); } for (lineno = 1; fgets(linebuf, sizeof linebuf, inf); lineno++) process_line(); fclose(inf); fclose(outf); if (record_count) exit(0); fprintf(stderr, "error: %s is empty\n", infname); exit(ERROR_USAGE); }