FreeCalypso > hg > freecalypso-tools
view librftab/smallconv.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | b73c21a2148f |
children |
line wrap: on
line source
/* * /gsm/rf/afcdac and /gsm/rf/stdmap each store a single 16-bit value, * and are not tables in the rftw/rftr sense, hence the code in rftablewr.c * does not handle these two. However, in fc-cal2text we would like to * handle their conversion from binary to ASCII the same way as the bigger * tables, hence the two functions in this module. */ #include <sys/types.h> #include <stdio.h> #include <stdint.h> #include <endian.h> void write_afcdac_ascii(bin, outf) uint16_t *bin; FILE *outf; { int i; i = le16toh(*bin); if (i >= 32768) i -= 65536; fprintf(outf, "%d\n", i); } void write_stdmap_ascii(bin, outf) uint16_t *bin; FILE *outf; { int i; i = le16toh(*bin); fprintf(outf, "0x%04X\n", i); }