FreeCalypso > hg > freecalypso-tools
view loadtools/ltscript.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 6616f4e35579 |
children |
line wrap: on
line source
/* * This module contains the code that implements the loadtool scripting * functionality: init-script setting and the exec command. */ #include <sys/param.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> extern char default_helpers_dir[]; loadtool_exec_script(script_name, is_init_script) char *script_name; { char pathbuf[MAXPATHLEN], *openfname; FILE *f; char linebuf[512], *cp; int lineno, retval = 0; if (!is_init_script || index(script_name, '/')) openfname = script_name; else { sprintf(pathbuf, "%s/%s", default_helpers_dir, script_name); openfname = pathbuf; } f = fopen(openfname, "r"); if (!f) { perror(openfname); return(-1); } for (lineno = 1; fgets(linebuf, sizeof linebuf, f); lineno++) { cp = index(linebuf, '\n'); if (!cp) { fprintf(stderr, "%s line %d: missing newline\n", openfname, lineno); fclose(f); return(-1); } *cp = '\0'; retval = loadtool_dispatch_cmd(linebuf, 1); if (retval) break; } fclose(f); return(retval); } cmd_exec(argc, argv) char **argv; { return loadtool_exec_script(argv[1], 0); }