view loadtools/simup.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 02490e26f53d
children
line wrap: on
line source

/*
 * This module implements the stage in fc-simint where the sim-up
 * command is fed to simagent and the ATR response is parsed.
 */

#include <sys/types.h>
#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>

extern int sim_voltage_mode_1v8;

#define	MAX_ATR_BYTES	33

u_char sim_atr[MAX_ATR_BYTES];
unsigned sim_atr_len;

static
sim_up_callback(line)
	char *line;
{
	char *cp;

	puts(line);
	if (strncmp(line, "ATR:", 4))
		return(1);
	sim_atr_len = 0;
	for (cp = line + 4; *cp; cp += 3) {
		if (cp[0] != ' ' || !isxdigit(cp[1]) || !isxdigit(cp[2])) {
			fprintf(stderr,
				"error: invalid ATR line from simagent\n");
			return(1);
		}
		if (sim_atr_len >= MAX_ATR_BYTES) {
			fprintf(stderr,
				"error: ATR from simagent is too long\n");
			return(1);
		}
		sim_atr[sim_atr_len++] = decode_hex_byte(cp + 1);
	}
	return(0);
}

void
do_sim_up()
{
	char *targv[3];

	printf("Bringing up SIM interface at %s V\n",
		sim_voltage_mode_1v8 ? "1.8" : "3.0");
	targv[0] = "sim-up";
	targv[1] = sim_voltage_mode_1v8 ? "1.8" : "3";
	targv[2] = 0;
	tpinterf_make_cmd(targv);
	if (tpinterf_send_cmd() < 0)
		exit(1);
	if (tpinterf_capture_output(20, sim_up_callback))
		exit(1);
	if (!sim_atr_len) {
		fprintf(stderr, "error: no ATR returned from simagent\n");
		exit(1);
	}
}