FreeCalypso > hg > freecalypso-tools
view rvinterf/asyncshell/parse.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * This module implements the parser helper function that allows * the same code to be reused between interactive and one-shot * versions of the same command. */ #include <stdio.h> #include <ctype.h> #include <string.h> #include <strings.h> #include <stdlib.h> parse_interactive_command_into_argv(argstr, argv, min_arg, max_arg, argcp) char *argstr, **argv; int min_arg, max_arg, *argcp; { char *cp, **ap; cp = argstr; for (ap = argv; ; ) { while (isspace(*cp)) cp++; if (!*cp || *cp == '#') break; if (ap - argv >= max_arg) { printf("error: too many arguments\n"); return(-1); } if (*cp == '"') { *ap++ = ++cp; while (*cp && *cp != '"') cp++; if (*cp != '"') { printf("error: unterminated quoted string\n"); return(-1); } *cp++ = '\0'; } else { *ap++ = cp; while (*cp && !isspace(*cp)) cp++; if (*cp) *cp++ = '\0'; } } if (ap - argv < min_arg) { printf("error: too few arguments\n"); return(-1); } *ap = 0; *argcp = ap - argv; return(0); }