view rvinterf/asyncshell/sendarb.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents d43d82cbfb85
children
line wrap: on
line source

/*
 * Command for sending arbitrary packets to the target
 */

#include <sys/types.h>
#include <stdio.h>
#include <ctype.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include "limits.h"
#include "exitcodes.h"

cmd_send_common(argc, argv)
	char **argv;
{
	u_char sendpkt[MAX_PKT_TO_TARGET];
	unsigned pktlen = argc, i;
	char *endp;

	for (i = 0; i < pktlen; i++) {
		sendpkt[i] = strtoul(argv[i], &endp, 16);
		if (*endp) {
			printf(
		"error: all arguments to send command must be hex bytes\n");
			return(ERROR_USAGE);
		}
	}
	/* send it! */
	send_pkt_to_target(sendpkt, pktlen);
	return(0);
}

void
cmd_send_interactive(argstr)
	char *argstr;
{
	char *argv[MAX_PKT_TO_TARGET+1];
	int argc, rc;

	rc = parse_interactive_command_into_argv(argstr, argv, 1,
						 MAX_PKT_TO_TARGET, &argc);
	if (rc < 0)
		return;
	cmd_send_common(argc, argv);
}

cmd_send_oneshot(argc, argv)
	char **argv;
{
	return cmd_send_common(argc - 1, argv + 1);
}