FreeCalypso > hg > freecalypso-tools
view rvinterf/lowlevel/tchhide.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | a1065c17429c |
children |
line wrap: on
line source
/* * One of several FreeCalypso extensions to RVTMUX is TCH bit access * logical channel, and we would like to handle it specially in rvinterf * because it's extremely chatty, sending a frame every 20 ms. If we * were to output every TCH frame in our regular log, that log output * becomes useless as everything else is drowned out. Therefore, we * implement a hiding mode by default: we only count how many TCH packets * were exchanged in between other messages of interest, and report these * counts. */ #include <stdio.h> extern void (*output_hook)(); unsigned tch_rx_count, tch_tx_count; static void tch_report_hook() { char msgbuf[80]; output_hook = 0; if (tch_rx_count) { sprintf(msgbuf, "TCH: received %u packet%s", tch_rx_count, tch_rx_count != 1 ? "s" : ""); output_line(msgbuf); tch_rx_count = 0; } if (tch_tx_count) { sprintf(msgbuf, "TCH: sent %u packet%s", tch_tx_count, tch_tx_count != 1 ? "s" : ""); output_line(msgbuf); tch_tx_count = 0; } } void tch_inc_count_rx() { tch_rx_count++; output_hook = tch_report_hook; } void tch_inc_count_tx() { tch_tx_count++; output_hook = tch_report_hook; }