FreeCalypso > hg > freecalypso-tools
view rvinterf/old/before-rvinterf/packetrx.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * This module handles the lowest level of serial packet Rx */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include "pktmux.h" extern int target_fd; #define MAXPKT 512 u_char rxpkt[MAXPKT]; size_t rxpkt_len; extern char pr_item[]; static int in_pkt, dle_state, toobig; static void process_inbyte(inb) { if (!in_pkt) { if (inb != STX || dle_state) { rxpkt_len++; dle_state = (inb == DLE); return; } if (rxpkt_len) { sprintf(pr_item, "Warning: Rx %u byte%s outside of a packet", (unsigned)rxpkt_len, rxpkt_len != 1 ? "s" : ""); print_item(); rxpkt_len = 0; } in_pkt = 1; toobig = 0; return; } if (dle_state) { dle_state = 0; if (inb != STX && inb != DLE) { sprintf(pr_item, "Rx framing error: %02X after DLE\n", inb); print_item(); in_pkt = 0; rxpkt_len = 0; return; } goto data; } if (inb == DLE) { dle_state = 1; return; } else if (inb == STX) { if (!rxpkt_len) return; in_pkt = 0; handle_rx_packet(); rxpkt_len = 0; return; } data: if (rxpkt_len >= MAXPKT) { if (!toobig) { sprintf(pr_item, "Error: Rx packet too big!\n"); print_item(); toobig = 1; } return; } rxpkt[rxpkt_len++] = inb; } void process_serial_rx() { u_char rdbuf[512]; int cc, i; cc = read(target_fd, rdbuf, sizeof rdbuf); if (cc <= 0) { perror("Error/EOF reading from target"); exit(1); } for (i = 0; i < cc; i++) process_inbyte(rdbuf[i]); }