FreeCalypso > hg > freecalypso-tools
view rvinterf/tmsh/omw.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | c81d0e9ac3b4 |
children |
line wrap: on
line source
/* * Old-style memory write command */ #include <sys/types.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "pktmux.h" #include "limits.h" #include "localtypes.h" #include "tm3.h" #include "exitcodes.h" cmd_omw(argc, argv) char **argv; { u32 addr, v; u_char cmdpkt[MAX_PKT_TO_TARGET]; int di; char **ap; addr = strtoul(argv[1], 0, 16); cmdpkt[1] = MEM_WRITE; cmdpkt[2] = addr; cmdpkt[3] = addr >> 8; cmdpkt[4] = addr >> 16; cmdpkt[5] = addr >> 24; di = 6; for (ap = argv + 2; *ap; ap++) { v = strtoul(*ap, 0, 16); cmdpkt[di++] = v; } send_etm_cmd(cmdpkt, di - 1); return(0); }