FreeCalypso > hg > freecalypso-tools
view rvinterf/tmsh/oneshot.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 27c41e4b21ae |
children |
line wrap: on
line source
/* * This module implements the one-shot mode of operation for fc-tmsh. */ #include <sys/types.h> #include <sys/errno.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include "exitcodes.h" extern int oneshot_nowait; extern int sock; extern int got_tm_response; oneshot_command(argc, argv) char **argv; { fd_set fds; int rc; if (!oneshot_nowait) init(); /* to catch the response properly */ rc = dispatch_oneshot_cmd(argc, argv); if (rc) exit(rc); if (oneshot_nowait) exit(0); /* wait for response */ for (;;) { FD_ZERO(&fds); FD_SET(sock, &fds); rc = select(sock+1, &fds, 0, 0, 0); if (rc < 0) { if (errno == EINTR) continue; perror("select"); exit(ERROR_UNIX); } if (FD_ISSET(sock, &fds)) handle_rvinterf_input(); if (got_tm_response) exit(0); } }