FreeCalypso > hg > freecalypso-tools
view target-utils/c139explore/dac.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | ce636b0ffb3d |
children |
line wrap: on
line source
/* * Code for exercising Motorola's vibrator, which is driven * via the Iota auxiliary DAC on this phone. */ #include <sys/types.h> #include "types.h" #include "abbdefs.h" extern u_long strtoul(); void cmd_dacon() { abb_reg_write(TOGBR1, 0x20); } void cmd_dac(argbulk) char *argbulk; { char *argv[2]; u32 val; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; val = strtoul(argv[0], 0, 0); if (val > 0x3FF) { printf("ERROR: argument out of range\n"); return; } abb_reg_write(AUXDAC, val); } void cmd_vibe(argbulk) char *argbulk; { char *argv[2]; u32 val; int c; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; val = strtoul(argv[0], 0, 0); if (val > 0x3FF) { printf("ERROR: argument out of range\n"); return; } abb_reg_write(AUXDAC, val); for (;;) { c = serial_in_poll(); if (c >= 0) break; } abb_reg_write(AUXDAC, 0); }