FreeCalypso > hg > freecalypso-tools
view target-utils/flash-boot-test/watchdog.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 3d7b546c710c |
children |
line wrap: on
line source
#include <sys/types.h> #include "types.h" void cmd_wd() { /* stop/disable the watchdog timer */ *(volatile u16 *)0xFFFFF804 = 0xF5; *(volatile u16 *)0xFFFFF804 = 0xA0; } void cmd_we() { /* watchdog enable */ *(volatile u16 *)0xFFFFF804 = 0x8000; } void cmd_wr() { /* read and display watchdog downcount register */ printf("%04X\n", *(volatile u16 *)0xFFFFF802); } void cmd_ww(argbulk) char *argbulk; { /* single or double write to WATCHDOG_TIM_MODE */ char *argv[3]; u_long w1, w2; if (parse_args(argbulk, 1, 2, argv, 0) < 0) return; if (parse_hexarg(argv[0], 4, &w1) < 0) { printf("ERROR: arg1 must be a valid 16-bit hex value\n"); return; } if (argv[1] && parse_hexarg(argv[1], 4, &w2) < 0) { printf("ERROR: arg2 must be a valid 16-bit hex value\n"); return; } /* do it */ *(volatile u16 *)0xFFFFF804 = w1; if (argv[1]) *(volatile u16 *)0xFFFFF804 = w2; }