FreeCalypso > hg > freecalypso-tools
view target-utils/libbase/osmodelay.S @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Fri, 01 Sep 2023 07:33:51 +0000 |
| parents | e7502631a0f9 |
| children |
line wrap: on
line source
/* * This assembly module provides a replica of OsmocomBB's bogo-millisecond * delay_ms() function. It is literally a copy of what OsmocomBB's delay_ms() * compiles to with their gcc version and their optimization settings, as seen * by doing arm-elf-objdump on their lib/delay.o. * * This hack is intended for those cases where we have to copy OsmocomBB's * black magic voodoo operations with no ability to understand what is actually * needed, such as SPCA552E initialization on the Pirelli DP-L10. */ .text .code 32 .globl osmo_delay_ms osmo_delay_ms: mov r3, #0 sub sp, sp, #4 str r3, [sp] ldr r3, =1300 mul r3, r0, r3 b 2f 1: ldr r2, [sp] ldr r2, [sp] add r2, r2, #1 str r2, [sp] 2: ldr r2, [sp] cmp r2, r3 bcc 1b add sp, sp, #4 bx lr