FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/abbcmd.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 44a1de4264d8 |
children |
line wrap: on
line source
/* * abbr pg reg -- read ABB register * abbw pg reg val -- write ABB register */ #include <sys/types.h> #include "types.h" #include "abbdefs.h" extern u_long strtoul(); extern u16 abb_reg_read(); extern void abb_reg_write(); void cmd_abbr(argbulk) char *argbulk; { char *argv[3]; u32 pg, reg, val; if (parse_args(argbulk, 2, 2, argv, 0) < 0) return; pg = strtoul(argv[0], 0, 0); reg = strtoul(argv[1], 0, 0); if (pg > 2 || reg > 31) { printf("ERROR: argument(s) out of range\n"); return; } abb_init(); val = abb_reg_read(PAGE(pg) | reg); printf("%03X\n", val); } void cmd_abbw(argbulk) char *argbulk; { char *argv[4]; u32 pg, reg, val; if (parse_args(argbulk, 3, 3, argv, 0) < 0) return; pg = strtoul(argv[0], 0, 0); reg = strtoul(argv[1], 0, 0); val = strtoul(argv[2], 0, 16); if (pg > 2 || reg > 31 || val > 0x3FF) { printf("ERROR: argument(s) out of range\n"); return; } abb_init(); abb_reg_write(PAGE(pg) | reg, val); }