FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/cmd_memdump_human.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | 9214118ae941 |
children |
line wrap: on
line source
/* * This is a human-oriented memory dump command. The dump is given in * both hex and ASCII, with readable spacing. */ #include <sys/types.h> #include "types.h" void cmd_memdump_human(argbulk) char *argbulk; { char *argv[3]; u_long start, length; u_long offset; u_char intbuf[16]; int i, c; if (parse_args(argbulk, 2, 2, argv, 0) < 0) return; if (parse_hexarg(argv[0], 8, &start) < 0) { printf("ERROR: arg1 must be a valid 32-bit hex address\n"); return; } if (parse_hexarg(argv[1], 8, &length) < 0) { printf("ERROR: arg2 must be a valid 32-bit hex value (length)\n"); return; } if (start & 0xF || length & 0xF) { printf("ERROR: implementation limit: 16-byte alignment required\n"); return; } for (offset = 0; offset < length; offset += 0x10) { memcpy(intbuf, start + offset, 0x10); printf("%08X: ", start + offset); for (i = 0; i < 16; i++) { printf("%02X ", intbuf[i]); if ((i & 3) == 3) putchar(' '); } for (i = 0; i < 16; i++) { c = intbuf[i]; if (c >= ' ' && c <= '~') putchar(c); else putchar('.'); } putchar('\n'); } }