FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/defgetchar.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | f9d2ce6591b7 |
children |
line wrap: on
line source
/* * The interactive command entry (editing) function in libcommon * will call mygetchar() for its character input. It is supposed * to be a blocking wait for input, but in some programs other * processing can be done while waiting - for example, check for * keypad presses as well. This is the basic version which waits * for serial input and nothing else - specific programs can * override it if necessary, but this library version is the default. */ extern int serial_in_poll(); int mygetchar() { register int c; do c = serial_in_poll(); while (c < 0); return c; }