view target-utils/loadagent/cmd_memload.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 0da2cf5a999c
children
line wrap: on
line source

/*
 * This module implements the ML (memory load) command, which will be
 * used by fc-chainload.
 *
 * The sole argument to the ML command is the body of an S3 record
 * with the initial "S3" characters stripped, i.e., starting with the
 * "count" byte, followed by the address, data and checksum bytes
 * exactly as in the original S3 record.
 */

#include "types.h"

void
cmd_memload(argbulk)
	char *argbulk;
{
	char *argv[2], *s;
	u8 srecbin[256], cksum;
	int len, i, c;
	u32 addr;

	if (parse_args(argbulk, 1, 1, argv, 0) < 0)
		return;
	s = argv[0];
	if (decode_hex_digits(s, 2, &len) < 0) {
inv:		printf("ERROR: ML argument is invalid\n");
		return;
	}
	s += 2;
	if (len < 6)
		goto inv;
	srecbin[0] = len;
	for (i = 1; i <= len; i++) {
		if (decode_hex_digits(s, 2, &c) < 0)
			goto inv;
		s += 2;
		srecbin[i] = c;
	}
	cksum = 0;
	for (i = 0; i <= len; i++)
		cksum += srecbin[i];
	if (cksum != 0xFF) {
		printf("ERROR: bad ML S-record checksum\n");
		return;
	}
	len -= 5;
	addr =  ((u32)srecbin[1] << 24) |
		((u32)srecbin[2] << 16) |
		((u32)srecbin[3] << 8) |
		 (u32)srecbin[4];
	memcpy(addr, srecbin + 5, len);
}