view target-utils/simagent/tx.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 289733ff272b
children
line wrap: on
line source

/*
 * This module implements transmission of bytes toward the SIM.
 */

#include "types.h"
#include "simregs.h"

extern u16 conf1_reg;

send_to_sim(bytes, count)
	u8 *bytes;
	unsigned count;
{
	unsigned n, timeout, delay;

	if (conf1_reg & SIM_CONF1_ETU)
		delay = 6000;
	else
		delay = 30000;
	SIMREGS.conf1 = conf1_reg |= SIM_CONF1_TXRX;
	if (count == 1)
		wait_ARM_cycles(delay);
	(void) SIMREGS.it;
	for (n = 0; ; ) {
		SIMREGS.dtx = bytes[n++];
		if (n == count) {
			SIMREGS.conf1 = conf1_reg &= ~SIM_CONF1_TXRX;
			return(0);
		}
		wait_ARM_cycles(delay);
		for (timeout = 12000; timeout; timeout--)
			if (SIMREGS.it & SIM_IT_ITTX)
				break;
		if (!timeout) {
			printf("ERROR: SIM interface Tx timeout on byte %u\n",
				n);
			return(-1);
		}
	}
}

void
cmd_tx(argstr)
	char *argstr;
{
	u8 bytes[5];
	int rc;

	rc = decode_hex_string_arg(argstr, bytes, sizeof bytes);
	if (rc < 0)
		return;
	if (rc == 0) {
		printf("ERROR: empty hex string argument\n");
		return;
	}
	send_to_sim(bytes, rc);
}