FreeCalypso > hg > freecalypso-tools
view target-utils/simtest/poll.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | d96ea6ae6aa5 |
children |
line wrap: on
line source
#include <sys/types.h> #include <strings.h> #include "types.h" #include "simregs.h" extern int serial_in_poll(); int enable_poll; void poll_sim_rx() { u32 drx; if (SIMREGS.stat & SIM_STAT_FEMPTY) return; drx = SIMREGS.drx & 0xFF; printf("%02X ", drx); } int mygetchar() { register int c; do { if (enable_poll) poll_sim_rx(); c = serial_in_poll(); } while (c < 0); return c; } void cmd_poll(argbulk) char *argbulk; { char *argv[2]; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (!strcmp(argv[0], "on")) enable_poll = 1; else if (!strcmp(argv[0], "off")) enable_poll = 0; else printf("ERROR: \"on\" or \"off\" argument expected\n"); }