view uptools/atcmd/resp_parse.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 02d6c8469535
children
line wrap: on
line source

/*
 * Parsing of structured responses to AT commands
 */

#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include "resp_parse.h"

parse_structured_response(start, fields, max_fields)
	char *start;
	struct resp_field *fields;
	int max_fields;
{
	char *cp;
	int fieldcnt;

	cp = start;
	for (fieldcnt = 0; fieldcnt < max_fields; fieldcnt++) {
		if (*cp == '\0')
			break;
		if (isdigit(*cp)) {
			fields[fieldcnt].type = RESP_FIELD_NUMBER;
			fields[fieldcnt].num = strtoul(cp, 0, 10);
			while (isdigit(*cp))
				cp++;
		} else if (*cp == '"') {
			cp++;
			fields[fieldcnt].type = RESP_FIELD_STRING;
			fields[fieldcnt].str = cp;
			while (*cp && *cp != '"')
				cp++;
			if (*cp != '"')
				return(-1);
			*cp++ = '\0';
		} else if (*cp == ',')
			fields[fieldcnt].type = RESP_FIELD_EMPTY;
		else
			return(-1);
		if (*cp == ',')
			cp++;
		else if (*cp)
			return(-1);
	}
	return fieldcnt;
}