FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/smsend_pdugen.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | a38805b5b6d4 |
children |
line wrap: on
line source
/* * This module implements the encoding part of SMS sending/writing in PDU mode. */ #include <sys/types.h> send_in_pdu_mode(da, textsrc, textlen, udh, udhl) u_char *da, *textsrc, *udh; unsigned textlen, udhl; { u_char pdu[158]; unsigned pdulen; char pduhex[317]; pdu[0] = 0; pdulen = make_sms_submit_pdu(da, 0, 0, textsrc, textlen, udh, udhl, pdu + 1); make_hex_string(pdu, pdulen + 1, pduhex); send_pdu_out(pduhex, pdulen); } send_pdu_ucs2(da, textsrc, textlen, udh, udhl) u_char *da, *udh; u_short *textsrc; unsigned textlen, udhl; { u_char ucs2_be[140], pdu[158]; unsigned pdulen; char pduhex[317]; ucs2_out_bigend(textsrc, ucs2_be, textlen); pdu[0] = 0; pdulen = make_sms_submit_pdu_8bit(da, 0, 0x08, ucs2_be, textlen * 2, udh, udhl, pdu + 1); make_hex_string(pdu, pdulen + 1, pduhex); send_pdu_out(pduhex, pdulen); }