FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/smsend_pduout.c @ 965:2969032bdfac
fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing
The only 100% safe way to pass a NULL pointer as a function argument
in K&R C is to cast 0 to a pointer type; failing to do so may cause
mysterious bugs (invalid stack frames or garbage in argument registers)
on 64-bit machines. This issue has already been fixed in most of
FC host tools, but I just found some missed spots: passing of NULL UDH
to PDU encoding functions in fcup-smsend[mult] in the case of single
(not concatenated) SMS.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Fri, 01 Sep 2023 07:33:51 +0000 |
parents | dc2fd8e6f42c |
children |
line wrap: on
line source
/* * This module implements the output part of SMS sending/writing in PDU mode. */ #include <stdio.h> extern void cmgw_callback(); extern int sms_write_mode; prep_for_pdu_mode() { atinterf_exec_cmd_needok("AT+CMGF=0", (char *) 0, (void *) 0); } send_pdu_out(pduhex, pdulen) char *pduhex; unsigned pdulen; { char *cmdname; void (*callback)(); char send_cmd[32]; if (sms_write_mode) { cmdname = "CMGW"; callback = cmgw_callback; } else { cmdname = "CMGS"; callback = 0; } sprintf(send_cmd, "AT+%s=%u", cmdname, pdulen); atinterf_exec_cmd_needok(send_cmd, pduhex, callback); }