view uptools/libcoding/sms_submit8.c @ 965:2969032bdfac

fcup-smsend[mult]: fix buglet in K&R C NULL pointer passing The only 100% safe way to pass a NULL pointer as a function argument in K&R C is to cast 0 to a pointer type; failing to do so may cause mysterious bugs (invalid stack frames or garbage in argument registers) on 64-bit machines. This issue has already been fixed in most of FC host tools, but I just found some missed spots: passing of NULL UDH to PDU encoding functions in fcup-smsend[mult] in the case of single (not concatenated) SMS.
author Mychaela Falconia <falcon@freecalypso.org>
date Fri, 01 Sep 2023 07:33:51 +0000
parents 759cb6dc501b
children
line wrap: on
line source

/*
 * This library module implements the function for constructing outgoing
 * SMS-SUBMIT PDUs, 8-bit version for raw data or UCS-2.
 */

#include <sys/types.h>
#include <strings.h>

make_sms_submit_pdu_8bit(da, pid, dcs, textsrc, textlen, udh, udhl, outbuf)
	u_char *da, *textsrc, *udh, *outbuf;
	unsigned textlen, udhl;
{
	u_char *outp = outbuf;
	unsigned addr_field_len;
	unsigned udh_octets;
	unsigned udl;

	if (udh)
		*outp++ = 0x41;
	else
		*outp++ = 0x01;
	*outp++ = 0;
	addr_field_len = ((da[0] + 1) >> 1) + 2;
	bcopy(da, outp, addr_field_len);
	outp += addr_field_len;
	*outp++ = pid;
	*outp++ = dcs;
	if (udh)
		udh_octets = udhl + 1;
	else
		udh_octets = 0;
	udl = udh_octets + textlen;
	*outp++ = udl;
	if (udh) {
		*outp++ = udhl;
		bcopy(udh, outp, udhl);
		outp += udhl;
	}
	bcopy(textsrc, outp, textlen);
	outp += textlen;
	return (outp - outbuf);
}