FreeCalypso > hg > freecalypso-tools
view rvinterf/asyncshell/sendarb.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | d43d82cbfb85 |
children |
line wrap: on
line source
/* * Command for sending arbitrary packets to the target */ #include <sys/types.h> #include <stdio.h> #include <ctype.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "limits.h" #include "exitcodes.h" cmd_send_common(argc, argv) char **argv; { u_char sendpkt[MAX_PKT_TO_TARGET]; unsigned pktlen = argc, i; char *endp; for (i = 0; i < pktlen; i++) { sendpkt[i] = strtoul(argv[i], &endp, 16); if (*endp) { printf( "error: all arguments to send command must be hex bytes\n"); return(ERROR_USAGE); } } /* send it! */ send_pkt_to_target(sendpkt, pktlen); return(0); } void cmd_send_interactive(argstr) char *argstr; { char *argv[MAX_PKT_TO_TARGET+1]; int argc, rc; rc = parse_interactive_command_into_argv(argstr, argv, 1, MAX_PKT_TO_TARGET, &argc); if (rc < 0) return; cmd_send_common(argc, argv); } cmd_send_oneshot(argc, argv) char **argv; { return cmd_send_common(argc - 1, argv + 1); }