FreeCalypso > hg > freecalypso-tools
view rvinterf/etmsync/fspath.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * FFS pathname manipulation functions */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include "ffs.h" #include "limits.h" #include "ffslimits.h" #include "exitcodes.h" validate_ffs_pathname(cand) char *cand; { char *cp; int depth, c; cp = cand; if (*cp++ != '/') { fprintf(stderr, "error: FFS pathnames must be absolute\n"); return(-1); } for (depth = 0; *cp; depth++) { if (*cp == '/') { fprintf(stderr, "error: FFS pathname must not contain duplicate slashes\n"); return(-1); } for (c = 0; *cp && *cp != '/'; cp++) c++; if (c > MAX_FN_COMPONENT) { fprintf(stderr, "error: FFS pathname component is too long\n"); return(-1); } if (!*cp) continue; cp++; if (!*cp) { fprintf(stderr, "error: FFS pathname must not end with a trailing slash\n"); return(-1); } } if (depth > MAX_NAME_DEPTH) { fprintf(stderr, "error: FFS pathname exceeds depth limit\n"); return(-1); } return(depth); } char * pathname_for_ffs_child(parent, childbuf) char *parent, *childbuf; { int depth; char *cp; depth = validate_ffs_pathname(parent); if (depth < 0 || depth >= MAX_NAME_DEPTH) return(0); strcpy(childbuf, parent); cp = index(childbuf, '\0'); if (depth) *cp++ = '/'; return(cp); }