view rvinterf/libinterf/launchrvif.c @ 1011:6d9b10633f10

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents e40bb5a6c6b9
children
line wrap: on
line source

/*
 * This module implements the optional "behind the scenes" invokation
 * of rvinterf from client programs.
 */

#include <sys/types.h>
#include <sys/socket.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include "exitcodes.h"

static char rvinterf_pathname[] = "/opt/freecalypso/bin/rvinterf";

extern int sock;

char *rvinterf_ttyport, *rvinterf_Bopt, *rvinterf_lopt, *rvinterf_wopt;

launch_rvinterf(do_delay)
{
	int sp[2], rc;
	char *rvif_argv[11], Sarg[16], **ap;

	rc = socketpair(AF_UNIX, SOCK_STREAM, 0, sp);
	if (rc < 0) {
		perror("socketpair");
		exit(ERROR_UNIX);
	}
	sock = sp[0];
	sprintf(Sarg, "-S%d", sp[1]);
	ap = rvif_argv;
	*ap++ = "rvinterf";
	*ap++ = Sarg;
	*ap++ = "-n";
	if (rvinterf_Bopt) {
		*ap++ = "-B";
		*ap++ = rvinterf_Bopt;
	}
	if (rvinterf_lopt) {
		*ap++ = "-l";
		*ap++ = rvinterf_lopt;
	}
	if (rvinterf_wopt) {
		*ap++ = "-w";
		*ap++ = rvinterf_wopt;
	}
	*ap++ = rvinterf_ttyport;
	*ap = 0;
	rc = vfork();
	if (rc < 0) {
		perror("vfork for launching rvinterf");
		exit(ERROR_UNIX);
	}
	if (!rc) {
		/* we are in the child - do the exec */
		close(sp[0]);
		execv(rvinterf_pathname, rvif_argv);
		perror(rvinterf_pathname);
		_exit(1);
	}
	close(sp[1]);
	if (do_delay)
		usleep(30000);
	return 0;
}