view rvinterf/lowlevel/clientcmd.c @ 1011:6d9b10633f10

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents e7502631a0f9
children
line wrap: on
line source

/*
 * This rvinterf module implements the handling of client commands.
 */

#include <sys/types.h>
#include <stdio.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include <unistd.h>
#include "../include/pktmux.h"
#include "../include/limits.h"
#include "../include/localsock.h"
#include "client.h"

void
process_msg_from_client(cli)
	struct client *cli;
{
	int c;

	switch (cli->rx_buf[0]) {
	case CLI2RVI_WANT_RVTRACE:
		if (cli->rx_msglen != 9) {
			send_local_msg_to_client(cli, "-Bad command length");
			return;
		}
		c = cli->int_rvt_count;
		if (c >= MAX_RVT_INTEREST) {
			send_local_msg_to_client(cli,
					"-Error: too many RVT interests");
			return;
		}
		cli->int_rvt_mask[c] = cli->rx_buf[1] << 24 |
					cli->rx_buf[2] << 16 |
					cli->rx_buf[3] << 8 | cli->rx_buf[4];
		cli->int_rvt_match[c] = cli->rx_buf[5] << 24 |
					cli->rx_buf[6] << 16 |
					cli->rx_buf[7] << 8 | cli->rx_buf[8];
		cli->int_rvt_count++;
		send_local_msg_to_client(cli, "+OK");
		return;
	case CLI2RVI_WANT_MUXPROTO:
		if (cli->rx_msglen != 2) {
			send_local_msg_to_client(cli, "-Bad command length");
			return;
		}
		if (cli->rx_buf[1] < 0x12 || cli->rx_buf[1] > 0x1D) {
			send_local_msg_to_client(cli,
					"-Unsupported protocol MUX value");
			return;
		}
		cli->int_proto[cli->rx_buf[1] - 0x12] = 1;
		send_local_msg_to_client(cli, "+OK");
		return;
	case CLI2RVI_DROP_MUXPROTO:
		if (cli->rx_msglen != 2) {
			send_local_msg_to_client(cli, "-Bad command length");
			return;
		}
		if (cli->rx_buf[1] < 0x12 || cli->rx_buf[1] > 0x1D) {
			send_local_msg_to_client(cli,
					"-Unsupported protocol MUX value");
			return;
		}
		cli->int_proto[cli->rx_buf[1] - 0x12] = 0;
		send_local_msg_to_client(cli, "+OK");
		return;
	case CLI2RVI_RESET_PACKET_RX:
		cli->int_rvt_count = 0;
		bzero(cli->int_proto, sizeof(cli->int_proto));
		send_local_msg_to_client(cli, "+OK");
		return;
	case CLI2RVI_PKT_TO_TARGET:
		c = cli->rx_msglen - 1;
		if (c < 1 || c > MAX_PKT_TO_TARGET) {
			send_local_msg_to_client(cli,
						 "-Invalid Tx packet length");
			return;
		}
		send_pkt_to_target(cli->rx_buf + 1, c);
		log_sent_packet(cli->rx_buf + 1, c);
		return;
	case CLI2RVI_RAWBYTES_TO_TARGET:
		/* To be implemented */
	default:
		send_local_msg_to_client(cli, "-Unimplemented command");
	}
}