FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/hexstrings.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 0da2cf5a999c |
children |
line wrap: on
line source
/* * The decode_hex_digits() function contained in this module * will be used by the XRAM and flash loading commands * which take SREC-like long hex string arguments. */ #include <ctype.h> #include "types.h" decode_hex_digits(str, ndigits, valp) char *str; int ndigits; u32 *valp; { u32 accum; int i, c; accum = 0; for (i = 0; i < ndigits; i++) { c = *str++; if (!isxdigit(c)) return(-1); accum <<= 4; if (isdigit(c)) accum += c - '0'; else if (islower(c)) accum += c - 'a' + 10; else accum += c - 'A' + 10; } *valp = accum; return(0); }