FreeCalypso > hg > freecalypso-tools
view target-utils/libtiffs/rdinmem.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 9214118ae941 |
children |
line wrap: on
line source
#include <sys/types.h> #include "types.h" #include "struct.h" #include "globals.h" #include "macros.h" tiffs_read_into_ram(pathname, buf, maxlen, lenrtn) char *pathname; u8 *buf; size_t maxlen, *lenrtn; { int stat, cont; u8 *chunk_start; size_t chunk_size, real_len, roomleft; stat = tiffs_find_file(pathname, &chunk_start, &chunk_size, &cont); if (stat < 0) return(stat); if (chunk_size > maxlen) { toobig: printf("Error: %s is bigger than the read buffer\n", pathname); return(-1); } real_len = chunk_size; memcpy(buf, chunk_start, chunk_size); buf += chunk_size; roomleft = maxlen - chunk_size; while (cont) { stat = tiffs_get_segment(cont, &chunk_start, &chunk_size, &cont); if (stat < 0) return(stat); if (chunk_size > roomleft) goto toobig; real_len += chunk_size; memcpy(buf, chunk_start, chunk_size); buf += chunk_size; roomleft -= chunk_size; } if (lenrtn) *lenrtn = real_len; return(0); }