FreeCalypso > hg > freecalypso-tools
view target-utils/pln-ppb-test/erase.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | f34261bb3355 |
children |
line wrap: on
line source
/* * erase command for PPB special mode */ #include <sys/types.h> #include "types.h" void cmd_erase(argbulk) char *argbulk; { char *argv[2]; u_long addr; u16 buf[256]; int i; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (parse_hexarg(argv[0], 8, &addr) < 0) { printf("ERROR: argument must be a valid 32-bit hex address\n"); return; } if (addr & 1) { printf("ERROR: unaligned address\n"); return; } *(volatile u16 *)addr = 0x80; *(volatile u16 *)addr = 0x30; for (i = 0; i < 256; i++) buf[i] = *(volatile u16 *)addr; for (i = 0; i < 256; i++) printf("%04X%c", buf[i], (i & 15) == 15 ? '\n' : ' '); }