FreeCalypso > hg > freecalypso-tools
view target-utils/pln-ppb-test/mode_entry.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 6b87de9e385b |
children |
line wrap: on
line source
/* * mode-entry and mode-exit commands */ #include <sys/types.h> #include "types.h" void cmd_mode_entry(argbulk) char *argbulk; { char *argv[3]; u_long addr, mode; if (parse_args(argbulk, 2, 2, argv, 0) < 0) return; if (parse_hexarg(argv[0], 8, &addr) < 0) { printf("ERROR: arg1 must be a valid 32-bit hex address\n"); return; } if (addr & 0xFFFF) { printf("ERROR: address is not on 64 KiB boundary\n"); return; } if (parse_hexarg(argv[1], 4, &mode) < 0) { printf("ERROR: arg2 must be a valid 16-bit hex value\n"); return; } *(volatile u16 *)(addr + 0xAAA) = 0xAA; *(volatile u16 *)(addr + 0x554) = 0x55; *(volatile u16 *)(addr + 0xAAA) = mode; } void cmd_mode_exit(argbulk) char *argbulk; { char *argv[2]; u_long addr; if (parse_args(argbulk, 1, 1, argv, 0) < 0) return; if (parse_hexarg(argv[0], 8, &addr) < 0) { printf("ERROR: argument must be a valid 32-bit hex address\n"); return; } if (addr & 0xFFFF) { printf("ERROR: address is not on 64 KiB boundary\n"); return; } *(volatile u16 *)addr = 0x90; *(volatile u16 *)addr = 0x00; }