FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/resp_parse.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 02d6c8469535 |
children |
line wrap: on
line source
/* * Parsing of structured responses to AT commands */ #include <ctype.h> #include <stdio.h> #include <stdlib.h> #include "resp_parse.h" parse_structured_response(start, fields, max_fields) char *start; struct resp_field *fields; int max_fields; { char *cp; int fieldcnt; cp = start; for (fieldcnt = 0; fieldcnt < max_fields; fieldcnt++) { if (*cp == '\0') break; if (isdigit(*cp)) { fields[fieldcnt].type = RESP_FIELD_NUMBER; fields[fieldcnt].num = strtoul(cp, 0, 10); while (isdigit(*cp)) cp++; } else if (*cp == '"') { cp++; fields[fieldcnt].type = RESP_FIELD_STRING; fields[fieldcnt].str = cp; while (*cp && *cp != '"') cp++; if (*cp != '"') return(-1); *cp++ = '\0'; } else if (*cp == ',') fields[fieldcnt].type = RESP_FIELD_EMPTY; else return(-1); if (*cp == ',') cp++; else if (*cp) return(-1); } return fieldcnt; }