FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/smsend_pduout.c @ 1011:6d9b10633f10
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | dc2fd8e6f42c |
children |
line wrap: on
line source
/* * This module implements the output part of SMS sending/writing in PDU mode. */ #include <stdio.h> extern void cmgw_callback(); extern int sms_write_mode; prep_for_pdu_mode() { atinterf_exec_cmd_needok("AT+CMGF=0", (char *) 0, (void *) 0); } send_pdu_out(pduhex, pdulen) char *pduhex; unsigned pdulen; { char *cmdname; void (*callback)(); char send_cmd[32]; if (sms_write_mode) { cmdname = "CMGW"; callback = cmgw_callback; } else { cmdname = "CMGS"; callback = 0; } sprintf(send_cmd, "AT+%s=%u", cmdname, pdulen); atinterf_exec_cmd_needok(send_cmd, pduhex, callback); }