FreeCalypso > hg > freecalypso-tools
view rvinterf/asyncshell/oneshot.c @ 497:74610c4f10f7
target-utils: added 10 ms delay at the end of abb_power_off()
The deosmification of the ABB access code (replacement of osmo_delay_ms()
bogus delays with correctly-timed ones, which are significantly shorter)
had one annoying side effect: when executing the poweroff command from
any of the programs, one last '=' prompt character was being sent (and
received by the x86 host) as the Calypso board powers off. With delays
being shorter now, the abb_power_off() function was returning and the
standalone program's main loop was printing its prompt before the Iota chip
fully executed the switch-off sequence!
I thought about inserting an endless tight loop at the end of the
abb_power_off() function, but the implemented solution of a 10 ms delay
is a little nicer IMO because if the DEVOFF operation doesn't happen for
some reason in a manual hacking scenario, there won't be an artificial
blocker in the form of a tight loop keeping us from further poking around.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sat, 25 May 2019 20:44:05 +0000 |
parents | 10f4062e049b |
children | b55a81ce7497 |
line wrap: on
line source
/* * This module implements the one-shot command mode of fc-shell. */ #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "limits.h" #include "exitcodes.h" extern int cmd_key_oneshot(); extern int cmd_keydown_oneshot(); extern int cmd_keyup_oneshot(); extern int cmd_poweroff(); extern int cmd_send_oneshot(); extern int cmd_sp_oneshot(); extern int cmd_str_oneshot(); extern int cmd_tchdl_oneshot(); extern int cmd_tgtreset(); extern int cmd_unterm_oneshot(); static struct cmdtab { char *cmd; int minargs; int maxargs; int (*func)(); } cmdtab[] = { {"key", 1, 1, cmd_key_oneshot}, {"keydown", 1, 1, cmd_keydown_oneshot}, {"keyup", 1, 1, cmd_keyup_oneshot}, {"poweroff", 0, 0, cmd_poweroff}, {"send", 1, MAX_PKT_TO_TARGET, cmd_send_oneshot}, {"sp", 2, 2, cmd_sp_oneshot}, {"str", 1, 1, cmd_str_oneshot}, {"tch-dl", 1, 1, cmd_tchdl_oneshot}, {"tgtreset", 0, 0, cmd_tgtreset}, {"unterm", 1, 1, cmd_unterm_oneshot}, {0, 0, 0, 0} }; oneshot_command(argc, argv) char **argv; { struct cmdtab *tp; if (!strncmp(argv[0], "AT", 2) || !strncmp(argv[0], "at", 2)) { if (argc != 1) { fprintf(stderr, "error: AT command must be a single argument\n"); exit(ERROR_USAGE); } return oneshot_at_command(argv[0]); } for (tp = cmdtab; tp->cmd; tp++) if (!strcmp(tp->cmd, argv[0])) break; if (!tp->func) { fprintf(stderr, "error: \"%s\" is not a valid one-shot command\n", argv[0]); exit(ERROR_USAGE); } if (argc - 1 > tp->maxargs) { fprintf(stderr, "%s: too many arguments\n", tp->cmd); exit(ERROR_USAGE); } if (argc - 1 < tp->minargs) { fprintf(stderr, "%s: too few arguments\n", tp->cmd); exit(ERROR_USAGE); } return tp->func(argc, argv); }