FreeCalypso > hg > freecalypso-tools
view rvinterf/tmsh/abb.c @ 497:74610c4f10f7
target-utils: added 10 ms delay at the end of abb_power_off()
The deosmification of the ABB access code (replacement of osmo_delay_ms()
bogus delays with correctly-timed ones, which are significantly shorter)
had one annoying side effect: when executing the poweroff command from
any of the programs, one last '=' prompt character was being sent (and
received by the x86 host) as the Calypso board powers off. With delays
being shorter now, the abb_power_off() function was returning and the
standalone program's main loop was printing its prompt before the Iota chip
fully executed the switch-off sequence!
I thought about inserting an endless tight loop at the end of the
abb_power_off() function, but the implemented solution of a 10 ms delay
is a little nicer IMO because if the DEVOFF operation doesn't happen for
some reason in a manual hacking scenario, there won't be an artificial
blocker in the form of a tight loop keeping us from further poking around.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sat, 25 May 2019 20:44:05 +0000 |
parents | 2159f260ed13 |
children |
line wrap: on
line source
/* * In this module we are going to implement commands dealing with the ABB. */ #include <sys/types.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> #include "pktmux.h" #include "limits.h" #include "localtypes.h" #include "etm.h" #include "exitcodes.h" extern u_char rvi_msg[]; extern int rvi_msg_len; cmd_abbr(argc, argv) char **argv; { u32 page, reg; u_char cmdpkt[5]; page = strtoul(argv[1], 0, 0); reg = strtoul(argv[2], 0, 0); if (page > 1 || reg > 31) { printf("error: argument(s) out of range\n"); return(ERROR_USAGE); } cmdpkt[1] = ETM_CORE; cmdpkt[2] = TMCORE_OPC_CODEC_RD; cmdpkt[3] = page << 5 | reg; send_etm_cmd(cmdpkt, 3); return(0); } void abbr_response() { unsigned pg, reg, val; char buf[80]; if (rvi_msg[3]) { print_etm_pkt_raw("abbr error"); return; } if (rvi_msg_len != 9) { print_etm_pkt_raw("abbr malformed resp"); return; } pg = rvi_msg[5] >> 5; reg = rvi_msg[5] & 0x1F; val = rvi_msg[6] | rvi_msg[7] << 8; sprintf(buf, "abbr %u %u: %03X", pg, reg, val); async_msg_output(buf); } cmd_abbw(argc, argv) char **argv; { u32 page, reg, val; u_char cmdpkt[7]; page = strtoul(argv[1], 0, 0); reg = strtoul(argv[2], 0, 0); val = strtoul(argv[3], 0, 16); if (page > 1 || reg > 31 || val > 0x3FF) { printf("error: argument(s) out of range\n"); return(ERROR_USAGE); } cmdpkt[1] = ETM_CORE; cmdpkt[2] = TMCORE_OPC_CODEC_WR; cmdpkt[3] = page << 5 | reg; cmdpkt[4] = val; cmdpkt[5] = val >> 8; send_etm_cmd(cmdpkt, 5); return(0); } void abbw_response() { unsigned pg, reg; char buf[80]; if (rvi_msg[3]) { print_etm_pkt_raw("abbw error"); return; } if (rvi_msg_len != 7) { print_etm_pkt_raw("abbw malformed resp"); return; } pg = rvi_msg[5] >> 5; reg = rvi_msg[5] & 0x1F; sprintf(buf, "abbw %u %u OK", pg, reg); async_msg_output(buf); }