ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author
Mychaela Falconia <falcon@freecalypso.org>
date
Thu, 31 Aug 2023 19:38:18 +0000 (19 months ago)
parents
8ddb16a37273
children
line source
+ − CC= gcc
+ − CFLAGS= -O2
+ − PROGDIR=ffstools loadtools miscutil ringtools rvinterf tchtools uptools
+ − LIBDIR= libpwon librftab libserial
+ − SUBDIR= ${PROGDIR} ${LIBDIR}
+ −
+ − INSTALL_PREFIX= /opt/freecalypso
+ −
+ − all: ${SUBDIR}
+ −
+ − ffstools: librftab
+ − loadtools: libpwon libserial
+ − miscutil: libserial
+ − rvinterf: libpwon librftab libserial
+ − uptools: libserial
+ −
+ − ${SUBDIR}: FRC
+ − cd $@; ${MAKE} ${MFLAGS} CC=${CC} CFLAGS="${CFLAGS}"
+ −
+ − clean: FRC
+ − rm -f a.out core errs
+ − for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} clean); done
+ −
+ − install: FRC
+ − mkdir -p ${INSTALL_PREFIX}
+ − for i in ${PROGDIR}; do (cd $$i; ${MAKE} ${MFLAGS} \
+ − INSTALL_PREFIX=${INSTALL_PREFIX} install); done
+ − mkdir -p ${INSTALL_PREFIX}/scripts
+ − install -c -m 644 scripts/* ${INSTALL_PREFIX}/scripts
+ − if [ -d target-bin ]; then \
+ − mkdir -p ${INSTALL_PREFIX}/target-bin; \
+ − install -c -m 644 target-bin/* ${INSTALL_PREFIX}/target-bin; \
+ − fi
+ −
+ − FRC: