FreeCalypso > hg > freecalypso-tools
view Source-dirs @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | bf302e52c8ea |
children |
line wrap: on
line source
ffstools This directory subtree was originally created to hold the source for our TIFFS In Vitro Analyzer tool, but has since been extended to contain various tools that perform static (or "in vitro") transformations on various bits of data that go into the flash file system on our FreeCalypso GSM devices or are contained in other vendors' flash data structures. libpwon This simple library implements the functionality described in doc/Target-boot-control; it is used by loadtools and rvinterf. librftab A library for reading and writing RF parameter tables in our FreeCalypso ASCII format - see doc/RF_tables. libserial All of our host programs that operate on serial ports (the way in which we communicate with GSM device targets) go through libserial, i.e., our serial port handling code has been factored out into a common library. loadtools fc-loadtool, fc-iram, fc-xram and fc-compalram form the part of FC host tools called loadtools, which used to be its own package. fc-buzplay and fc-simint are also built in the loadtools suite because they use many of the same components. miscutil A few miscellaneous utilities are built here. openmoko This directory houses the modem-power-ctrl.sh script, provided for the benefit of those users who wish to run fc-loadtool on the application processor of Openmoko GTA02. ringtools Tools for working with ringtone melodies are built here. rvinterf Everything dealing with the RVTMUX interface to running GSM firmwares and everything based on the rvinterf framework is built under rvinterf. The tfc139 utility, which logically belongs with loadtools, is built in the rvinterf subtree because it is built from mostly the same source components as rvtdump and rvinterf. target-utils The source for loadagent and compalstage lives here, along with a few extra target utilities that are of interest only to developers. tchtools Tools for working with TCH DL recording and TCH UL play files (see doc/TCH-bit-access) and with TCS211 voice memo recordings (see doc/Voice-memo-utils) are built here. toolchain Scripts and patches for building the gcc+binutils toolchain targeting ARM7, the CPU core of the Calypso GSM/GPRS baseband processor. You'll need to build and install this toolchain first before you can build target-utils. uptools The User Phone Tools suite is built here - see doc/User-phone-tools.