FreeCalypso > hg > freecalypso-tools
view ffstools/caltools/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e5ef798e2d35 |
children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROGS= c1xx-calextr fc-add-ramps fc-bin2rftab fc-cal2bin fc-rftab2c INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin all: ${PROGS} LIBRFTAB= ../../librftab/librftab.a ADDRAMPS_OBJS= fc-add-ramps.o ${LIBRFTAB} BIN2RFTAB_OBJS= fc-bin2rftab.o ${LIBRFTAB} CAL2BIN_OBJS= fc-cal2bin.o ${LIBRFTAB} CALEXTR_OBJS= c1xx-calextr.o mkdir.o ${LIBRFTAB} RFTAB2C_OBJS= fc-rftab2c.o ${LIBRFTAB} fc-add-ramps: ${ADDRAMPS_OBJS} ${CC} ${CFLAGS} -o $@ ${ADDRAMPS_OBJS} fc-bin2rftab: ${BIN2RFTAB_OBJS} ${CC} ${CFLAGS} -o $@ ${BIN2RFTAB_OBJS} fc-cal2bin: ${CAL2BIN_OBJS} ${CC} ${CFLAGS} -o $@ ${CAL2BIN_OBJS} c1xx-calextr: ${CALEXTR_OBJS} ${CC} ${CFLAGS} -o $@ ${CALEXTR_OBJS} fc-rftab2c: ${RFTAB2C_OBJS} ${CC} ${CFLAGS} -o $@ ${RFTAB2C_OBJS} mkdir.o: ../cal2text/mkdir.c ${CC} ${CFLAGS} -c -o $@ $< install: mkdir -p ${INSTBIN} install -c ${PROGS} ${INSTBIN} clean: rm -f ${PROGS} *.o *errs *.out