FreeCalypso > hg > freecalypso-tools
view ffstools/caltools/fc-cal2bin.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 5bcf12be0834 |
children |
line wrap: on
line source
/* * This utility converts an RF table from ASCII to binary format. */ #include <sys/types.h> #include <sys/file.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> main(argc, argv) char **argv; { u_char buf[512]; unsigned size; int ofd; if (argc != 3) { fprintf(stderr, "usage: %s ascii-input-file binary-output-file\n", argv[0]); exit(1); } if (read_rf_table_ext(argv[1], buf, 1, (char **) 0, &size)) exit(1); ofd = open(argv[2], O_WRONLY|O_CREAT|O_TRUNC, 0666); if (ofd < 0) { perror(argv[2]); exit(1); } write(ofd, buf, size); close(ofd); exit(0); }