FreeCalypso > hg > freecalypso-tools
view ffstools/tiffs-rd/globals.h @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * extern declarations of global variables */ extern char *imgfile; extern off_t imgfile_offset; extern u32 eraseblk_size; extern int total_blocks; extern u32 total_ffs_size; extern int index_blk_num, root_inode; extern int inode_limit; extern int verbose, verbose2; extern int old_16bit_location; extern u8 *image, *inode_block; extern struct inode_info **inode_info;