FreeCalypso > hg > freecalypso-tools
view libpwon/duart28c.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 7d1df6d831e4 |
children |
line wrap: on
line source
#include <sys/types.h> #include <sys/ioctl.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include <unistd.h> extern int target_fd; int bootctrl_duart28c_mode; static int mctl_arg; bootctrl_check_duart28c(bc_name) char *bc_name; { if (!strcmp(bc_name, "dtr")) { bootctrl_duart28c_mode = 1; mctl_arg = TIOCM_DTR; return 1; } if (!strcmp(bc_name, "rts")) { bootctrl_duart28c_mode = 1; mctl_arg = TIOCM_RTS; return 1; } return 0; } void fork_duart28c_pulse() { int i; i = fork(); if (i < 0) { perror("fork"); exit(1); } if (i) return; ioctl(target_fd, TIOCMBIS, &mctl_arg); usleep(50000); ioctl(target_fd, TIOCMBIC, &mctl_arg); exit(0); }